Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

From: Roger Quadros
Date: Wed Jun 29 2016 - 02:17:25 EST


On 29/06/16 01:01, Stephen Boyd wrote:
> Quoting Roger Quadros (2016-06-28 02:13:57)
>> On 28/06/16 11:47, Stephen Boyd wrote:
>>>
>>> Sorry I must have confused you. There are two modules in the PMIC that
>>> are doing detection here. The charger module is detecting the VBUS event
>>> and this misc module is detecting the ID pin. I'm not sure why they're
>>> two different blocks, but it is what it is in the hardware.
>>>
>> OK. Can the MISC block do anything else other than USB ID?
>
> Yes.
>
>> Does the USB ID interrupt come on a different line than the charger interrupt?
>
> Yes.
>

OK. Is it better to have this driver somewhere in drivers/mfd or drivers/misc if the
other function doesn't need/use extcon?

>>
>> It would be more like MISC block interrupt than USB ID interrupt right?
>
> There are two interrupts going to two different hw blocks inside the
> PMIC.
>

cheers,
-roger