Re: [PATCH] PM / suspend: show workqueues busy name in suspend flow

From: Tejun Heo
Date: Wed Jun 29 2016 - 09:22:40 EST


Hello, Roger.

On Wed, Jun 29, 2016 at 11:54:11AM +0800, Roger Lu wrote:
> Please allow me to elaborate my previous concern about printing
> freezable workqueue info only in this case.
>
> The benefit of it is that debugger can quickly understand which
> freezable workqueues block suspend flow and assign this issue to
> corresponding owner instead of extracting freezable workqueue info from
> show_workqueue_state() first and, then, assigning the issue.

I don't think it matters. At that point, workqueues are generally
pretty idle anyway and it shouldn't be difficult to tell which work
items are the offending ones. Besides, freezable and unfreezable
workqueues share the same backend pools, so it isn't easily separable
either.

Thanks.

--
tejun