Re: [PATCH] kthread: to_live_kthread() needs try_get_task_stack()

From: Andy Lutomirski
Date: Wed Jun 29 2016 - 19:01:59 EST


On Wed, Jun 29, 2016 at 11:03 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> On 06/29, Andy Lutomirski wrote:
>>
>> I pushed that change to my tree (seems to work well enough to boot
>> without warnings as long as I don't unmount XFS, but not particularly
>> well tested). Want to refresh your patch on top?
>
> Please see the trivial fix below. Compile tested, but looks obvious.

I stuck it in my tree in the right place. Thanks!

>
> Btw, why free_thread_stack() calls vfree() with irqs disabled? Doesn't
> look good and perhaps even wrong; at least vmap_debug_free_range() does
> flush_tlb_kernel_range() and smp_call_function() can deadlock?

Whoops, that's a bug. Fixed now.

--Andy