Re: [PATCH 0/2] Input-at32psif: Fine-tuning for OOM handling in psif_probe()

From: SF Markus Elfring
Date: Sun Jul 03 2016 - 04:02:44 EST


>> A few update suggestions were taken into account
>> from static source code analysis.
>>
>> Markus Elfring (2):
>> Return directly after a failed kzalloc()
>> Remove two OOM messages
>>
>> drivers/input/serio/at32psif.c | 10 +++-------
>> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> What possible rationale is there for including this "references" header?
> 566ABCD9.1060404@xxxxxxxxxxxxxxxxxxxxx

Do any more software developers dare to reconsider source code
also around a jump label like "out"?


> This message id is for your message:
> "Source code review around jump label usage"
> sent December 11, 2015!

Can such an association with a bit of background information
be occasionally useful for clarification of corresponding
implementation details?

Regards,
Markus