Re: [PATCH v2 8/8] mm/zsmalloc: use helper to clear page->flags bit

[Sergey Senozhatsky]

On (07/04/16 14:49), Ganesh Mahendran wrote:
> Date: Mon,  4 Jul 2016 14:49:59 +0800
> From: Ganesh Mahendran <opensource.ganesh@xxxxxxxxx>
> To: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
> Cc: akpm@xxxxxxxxxxxxxxxxxxxx, minchan@xxxxxxxxxx, ngupta@xxxxxxxxxx,
>  sergey.senozhatsky.work@xxxxxxxxx, rostedt@xxxxxxxxxxx, mingo@xxxxxxxxxx,
>  Ganesh Mahendran <opensource.ganesh@xxxxxxxxx>
> Subject: [PATCH v2 8/8] mm/zsmalloc: use helper to clear page->flags bit
> X-Mailer: git-send-email 1.9.1
> 
> user ClearPagePrivate/ClearPagePrivate2 helper to clear
> PG_private/PG_private_2 in page->flags
> 
> Signed-off-by: Ganesh Mahendran <opensource.ganesh@xxxxxxxxx>
> Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

	-ss

> ----
> v2: none
> ---
>  mm/zsmalloc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 756f839..297f25b 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -940,8 +940,8 @@ static void unpin_tag(unsigned long handle)
>  static void reset_page(struct page *page)
>  {
>  	__ClearPageMovable(page);
> -	clear_bit(PG_private, &page->flags);
> -	clear_bit(PG_private_2, &page->flags);
> +	ClearPagePrivate(page);
> +	ClearPagePrivate2(page);
>  	set_page_private(page, 0);
>  	page_mapcount_reset(page);
>  	ClearPageHugeObject(page);
> -- 
> 1.9.1
>