Re: [PATCH] vfs: fix typo in link_path_walk()

From: Al Viro
Date: Mon Jul 04 2016 - 16:50:57 EST


On Mon, Jul 04, 2016 at 05:48:53PM +0100, Luis de Bethencourt wrote:
> Comment documenting the path parsing in link_path_walk() has a typo, fixing
> it.

> @@ -2064,7 +2064,7 @@ static int link_path_walk(const char *name, struct nameidata *nd)
> if (!*name)
> goto OK;
> /*
> - * If it wasn't NUL, we know it was '/'. Skip that
> + * If it wasn't NULL, we know it was '/'. Skip that

"If it wasn't <this>, we know it was <that>" really implies that <this> and
<that> are values possible for the same expression, doesn't it? How could
a pointer (NULL) and a character ('/') possibly be such?

Could you explain the meaning of thus "fixed" comment? I'm not even asking
to explain why it is correct that way, just what the hell is it supposed to
mean?

NAK, in case it's not obvious from the above...