Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

From: Linus Walleij
Date: Tue Jul 05 2016 - 02:52:49 EST


On Mon, Jul 4, 2016 at 10:30 PM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Monday 04 Jul 2016 15:16:40 Linus Walleij wrote:
>> On Sun, Jul 3, 2016 at 6:32 PM, Johan Hovold <johan@xxxxxxxxxx> wrote:
>> > This reverts commit 923b93e451db876d1479d3e4458fce14fec31d1c.
>>
>> Laurent, can we have you comment on this?
>>
>> Getting close to v4.7 final so we need to quickly see if
>> this is the solution or if it will cause further regressions on
>> your side if I revert it...
>
> Given that the offending patch dates from October 2015, why is the v4.7
> schedule an issue ?

Just convenient to cut a clean kernel and say that if people use
v4.7 or later they don't see the issue. Else you have to tell them to
use one or another stable kernel (which they should, for products etc)
which complicates things.

But you're right, it's no *big* deal in that sense.

Johan does use some alarmin language like destroyed hardware in
the patch description making me feel the issue is urgent though.
Given how long it has been there I don't know if it is really urgent
in practice and not only in theory.

Yours,
Linus Walleij