Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries

From: Mel Gorman
Date: Tue Jul 05 2016 - 06:55:34 EST


On Tue, Jul 05, 2016 at 04:07:23PM +0800, Hillf Danton wrote:
> > + /*
> > + * Would the allocation succeed if we reclaimed the whole
> > + * available? This is approximate because there is no
> > + * accurate count of reclaimable pages per zone.
> > + */
> > + for (zid = 0; zid <= zone_idx(zone); zid++) {
> > + struct zone *check_zone = &current_pgdat->node_zones[zid];
> > + unsigned long estimate;
> > +
> > + estimate = min(check_zone->managed_pages, available);
> > + if (__zone_watermark_ok(check_zone, order,
> > + min_wmark_pages(check_zone), ac_classzone_idx(ac),
> > + alloc_flags, available)) {
> > + }
> Stray indent?
>

Last minute rebase-related damage. I'll fix it.

--
Mel Gorman
SUSE Labs