Re: [PATCH] kernel/watchdog: use nmi registers snapshot in hardlockup handler

From: Jiri Kosina
Date: Thu Jul 07 2016 - 04:30:31 EST


On Tue, 5 Jul 2016, Konstantin Khlebnikov wrote:

> NMI handler doesn't call set_irq_regs(), so get_irq_regs() returns NULL or
> stale snapshot from beginning of IRQ interrupted by NMI. Registers from
> argument are always here and points to interrupted instruction and state.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>
> Cc: Jiri Kosina <jkosina@xxxxxxx>

Good catch, thanks for fixing my thinko.

Reviewed-by: Jiri Kosina <jkosina@xxxxxxx>

--
Jiri Kosina
SUSE Labs