Re: [PATCH v7 07/11] powerpc/powernv: Add platform support for stop instruction

From: Michael Neuling
Date: Fri Jul 08 2016 - 00:27:33 EST



> > >
> > > @@ -439,7 +540,18 @@ timebase_resync:
> > > Â Â*/
> > > Â bne cr4,clear_lock
> > > Â
> > > - /* Restore per core state */
> > > + /*
> > > + Â* First thread in the core to wake up and its waking up
> > > with
> > > + Â* complete hypervisor state loss. Restore per core
> > > hypervisor
> > > + Â* state.
> > > + Â*/
> > > +BEGIN_FTR_SECTION
> > > + ld r4,_PTCR(r1)
> > > + mtspr SPRN_PTCR,r4
> > > + ld r4,_RPR(r1)
> > > + mtspr SPRN_RPR,r4
> > RPR looks wrong here.ÂÂThis should be on POWER8 too.
> >
> > This has changed since v6 and not noted in the v7 comments.ÂÂWhy are
> > you
> > changing this now?
> >
> RPR is a per-core resource in P9. So with this patch, RPR will continue
> to be restored per-subcore in P8 and will restored once per core in P9.

Ok, thanks for the explanation.

Mikey