On 26/06/16 04:26, Guenter Roeck wrote:Thanks a lot for your feedback - it is reassuring that it looks sane to you.
Up to now, each hwmon driver has to implement its own sysfs attributes.Some cool stuff hiding in there :)
This requires a lot of template code, and distracts from the driver's
core function to read and write chip registers.
To be able to reduce driver complexity, move sensor attribute handling
and thermal zone registration into the hwmon core. By using the new API,
driver size is typically reduced by 20-50% depending on driver complexity
and the number of sysfs attributes supported.
The first patch of the series introduces the API as well as support
for temperature sensors. Subsequent patches introduce support for
voltage, current, power, energy, humidity, and fan speed sensors.
The series was tested by converting several drivers (lm75, lm90, tmp102,
tmp421, ltc4245) to the new API. Testing was done with with real chips
as well as with the hwmon driver module test code available at
I've only reviewed 1 and 7 and the intermediate ones are really either
correct or they aren't and they look fine to me.
Next steps will be to address your comments, re-test, submit a new series,
So what's next? (beyond presumably a lot of driver conversions).