Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel permits

From: Mark Rutland
Date: Mon Jul 11 2016 - 06:50:39 EST


On Fri, Jul 08, 2016 at 09:55:14AM +0200, Jiri Olsa wrote:
> On Thu, Jul 07, 2016 at 05:04:34PM +0100, Mark Rutland wrote:
> > + if (!cpu_map__has(evsel->cpus, evlist_cpu))
> > + continue;
> > +
> > + cpu = cpu_map__idx(evsel->cpus, evlist_cpu);
>
> you basicaly call cpu_map__idx twice in here,
> I think it might be better call it just once
> and check the cpu for -1

Sure, I can change the patch to do that.

Mark.