[patch 30/66] KVM: x86: Remove superfluous SMP function call

From: Anna-Maria Gleixner
Date: Mon Jul 11 2016 - 08:43:12 EST


From: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>

Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")
the CPU_ONLINE and CPU_DOWN_PREPARE notifiers are always run on the hot
plugged CPU, and as of commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during
error-out in __cpu_disable()") the CPU_DOWN_FAILED notifier also runs on the
hot plugged CPU. This patch converts the SMP functional calls into direct
calls.

smp_function_call_single() executes the function with interrupts
disabled. This calling convention is not preserved because there is no reason
to do so.

Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
---
arch/x86/kvm/x86.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -5667,10 +5667,10 @@ static int kvmclock_cpu_notifier(struct
switch (action) {
case CPU_ONLINE:
case CPU_DOWN_FAILED:
- smp_call_function_single(cpu, tsc_khz_changed, NULL, 1);
+ tsc_khz_changed(NULL);
break;
case CPU_DOWN_PREPARE:
- smp_call_function_single(cpu, tsc_bad, NULL, 1);
+ tsc_bad(NULL);
break;
}
return NOTIFY_OK;