Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

From: Coelho, Luciano
Date: Mon Jul 11 2016 - 12:07:50 EST

On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote:
> Didn't get any feedback or review comments on this patch.ÂÂResending
> ...
> P.

Sorry, this got flooded down my inbox.

> ---8<---
> The iwlwifi driver implements a thermal zone and hwmon device, but
> returns -EIO on temperature reads if the firmware isn't loaded.ÂÂThis
> results in the error
> iwlwifi-virtual-0
> Adapter: Virtual device
> ERROR: Can't get value of subfeature temp1_input: I/O error
> being output when using sensors from the lm-sensors package.ÂÂSince
> the temperature cannot be read unless the ucode is loaded there is no
> reason to add the interface only to have it return an error 100% of
> the time.
> This patch moves the firmware check to
> iwl_mvm_thermal_zone_register() and
> stops the thermal zone from being created if the ucode hasn't been
> loaded.
> Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
> Cc: Johannes Berg <johannes.berg@xxxxxxxxx>
> Cc: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> Cc: Luca Coelho <luciano.coelho@xxxxxxxxx>
> Cc: Intel Linux Wireless <linuxwifi@xxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: Chaya Rachel Ivgi <chaya.rachel.ivgi@xxxxxxxxx>
> Cc: Sara Sharon <sara.sharon@xxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> ---

I have now sent it for review on our internal tree.