Re: çå: BUG: INTx is assered unexpectly when unload AHCI driver with MSIx support.

From: tj@xxxxxxxxxx
Date: Tue Jul 12 2016 - 13:30:19 EST


Hello,

On Mon, Jul 11, 2016 at 05:16:00AM +0000, Pang Raymond wrote:
> static irqreturn_t ahci_multi_irqs_intr_hard(int irq,
> void *dev_instance)
> {
> // omitting unconcerned codes here
> // ...
> status = readl(port_mmio + PORT_IRQ_STAT);
> writel(status, port_mmio + PORT_IRQ_STAT);
>
> // add patch code here.
> + writel(1 << ap->port_no, ap->host->iomap + HOST_IRQ_STAT);
>
> // ...

I think it'd be better to avoid adding stuff to the hot path. This
only matters when the device is shut down, right? Can't it just be
cleared in the driver cleanup path?

Thanks.

--
tejun