Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable

From: Cong Wang
Date: Tue Jul 12 2016 - 13:36:57 EST


On Mon, Jul 11, 2016 at 7:02 AM, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index f45929c..0b5c172e 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -52,6 +52,7 @@
> #include <uapi/linux/netdevice.h>
> #include <uapi/linux/if_bonding.h>
> #include <uapi/linux/pkt_cls.h>
> +#include <linux/hashtable.h>
>
> struct netpoll_info;
> struct device;
> @@ -1778,6 +1779,7 @@ struct net_device {
> unsigned int num_tx_queues;
> unsigned int real_num_tx_queues;
> struct Qdisc *qdisc;
> + DECLARE_HASHTABLE (qdisc_hash, 4);
> unsigned long tx_queue_len;
> spinlock_t tx_global_lock;
> int watchdog_timeo;

Should it be surrounded by CONFIG_NET_SCHED?
To save several bytes for !CONFIG_NET_SCHED case.