Re: [PATCH v2 2/2] spi: add DT binding for clps711x SPI

From: Alexander Shiyan
Date: Wed Jul 13 2016 - 04:21:12 EST


>ÐÑÐÐÐ, 13 ÐÑÐÑ 2016, 11:13 +03:00 ÐÑ Arnd Bergmann <arnd@xxxxxxxx>:
>
>On Tuesday, July 12, 2016 3:49:47 PM CEST Rob Herring wrote:
>> On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote:
>> > +
>> > +An additional register is present in the system controller,
>> > +which is assumed to be in the same device tree, with and marked
>> > +as compatible with "cirrus,ep7209-syscon3".
>> > +
>> > +Example:
>> > +
>> > +spi@80000500 {
>> > + #address-cells = <1>;
>> > + #size-cells = <0>;
>> > + compatible = "cirrus,ep7209-spi";
>> > + reg = <0x80000500 0x4>;
>> > + interrupts = <15>;
>> > + clocks = <&clks CLPS711X_CLK_SPI>;
>> > + status = "disabled";
>> > +};
>> > +
>> > +syscon3: syscon@80002200 {
>>
>> This looks like it shouldn't be here.
>
>The label, or the entire node?

I think that the whole syscon3 node is redundant.

---