Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

From: Peter Chen
Date: Fri Jul 15 2016 - 03:21:07 EST


On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote:
> > > +
> > > +err_clks:
> > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev);
> >
> > If you have only one clock, it is unnecessary to use dedicated APIs for clock operation.
> >
>
> We do have multiple clocks, but currently one is integrated in code. Hence created
> the APIs for future use.

If you could not integrate one more clocks, I suggest not creating dedicated
API until you need in future.

--

Best Regards,
Peter Chen