Re: [PATCH V9 6/9] vfio: platform: call _RST method when using ACPI

From: Sinan Kaya
Date: Fri Jul 15 2016 - 21:09:45 EST


On 7/14/2016 6:04 PM, Alex Williamson wrote:
>> +static inline
>> > +bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev)
>> > +{
>> > +#ifdef CONFIG_ACPI
>> > + struct device *dev = vdev->device;
>> > + acpi_handle handle = ACPI_HANDLE(dev);
>> > +
>> > + return acpi_has_method(handle, "_RST");
>> > +#else
>> > + return false;
>> > +#endif
>> > +}
> What exactly is the rationale for making these inline? Clearly reset
> is not a performance relevant path. Thanks,
>
> Alex
>

It is remaining from the previous stub functions which were inline. I'll get rid
of the inlines.

--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.