Re: [patch] mtd: pmcmsp-flash: Allocating too much in init_msp_flash()
From: Brian Norris
Date: Sat Jul 16 2016 - 01:46:07 EST
On Thu, Jul 14, 2016 at 01:44:56PM +0300, Dan Carpenter wrote:
> There is a cut and paste issue here. The bug is that we are allocating
> more memory than necessary for msp_maps. We should be allocating enough
> space for a map_info struct (144 bytes) but we instead allocate enough
> for an mtd_info struct (1840 bytes). It's a small waste.
> The other part of this is not harmful but when we allocated msp_flash
> then we allocated enough space fro a map_info pointer instead of an
> mtd_info pointer. But since pointers are the same size it works out
> Anyway, I decided to clean up all three allocations a bit to make them
> a bit more consistent and clear.
> Fixes: 68aa0fa87f6d ('[MTD] PMC MSP71xx flash/rootfs mappings')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Applied to l2-mtd.git.