Re: [patch] crypto: sha256-mb - cleanup a || vs | typo

From: Pavel Machek
Date: Mon Jul 18 2016 - 04:59:13 EST


On Fri 2016-07-08 10:19:26, Linus Torvalds wrote:
> [ rare comment rant. I think I'll do this once, and then ignore the discussion ]
>
> On Fri, Jul 8, 2016 at 9:45 AM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Nack. As I said the commenting style in the crypto API is the
> > same as the network stack. So unless we decide to change both
> > please stick to the current style.
>
> Can we please get rid of the brain-damaged stupid networking comment
> syntax style, PLEASE?

Please? :-). Having different comment styles between networking and
the rest is confusing.

And yes, this uglyness is documented for net/ and drivers/net/, but
not for crypto/, so at the very least Documentation/CodingStyle should
be updated.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html