RE: [PATCH v3 2/8] thunderbolt: Updating device IDs
From: Levy, Amir (Jer)
Date: Mon Jul 18 2016 - 05:54:21 EST
On Sat, Jul 16 2016, 12:53 AM, David Miller wrote:
> From: "Levy, Amir (Jer)" <amir.jer.levy@xxxxxxxxx>
> Date: Fri, 15 Jul 2016 18:56:39 +0000
> > On Fri, Jul 15 2016, 09:49 PM, David Miller wrote:
> >> From: Amir Levy <amir.jer.levy@xxxxxxxxx>
> >> Date: Thu, 14 Jul 2016 14:28:16 +0300
> >> > Adding the new Thunderbolt(TM) device IDs to the list.
> >> >
> >> > Signed-off-by: Amir Levy <amir.jer.levy@xxxxxxxxx>
> >> Unless these PCI-IDs, all of them, are going to be used in multiple
> >> spots in the kernel, it is not appropriate to add them here.
> >> They belong as private macros in the drivers themselves, instead.
> > They might be used:
> > http://www.spinics.net/lists/linux-pci/msg51331.html
> Then move them to the common location when this "might" thing actually
There are several contradicting comments about this change (http://www.spinics.net/lists/linux-pci/msg51331.html and http://www.spinics.net/lists/linux-pci/msg51302.html)
I've decided for now to make the new device ids private to the driver.
This can be changed later when updating quirks for Apple hardware.