Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling
From: Kristian Evensen
Date: Mon Jul 18 2016 - 10:27:48 EST
On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum <oneukum@xxxxxxxx> wrote:
>> Ok, sounds good. So far, I have only seen the random MAC issue with
>> the three previously mentioned devices, but who knows how many else is
>> out there with the same error ... I don't think it should be in the
>> core ethernet code, at least not yet, but I agree it would make sense
>> to move it to for example usbnet_core(). If you agree, I can prepare a
>> patch for it.
> I don't see how it would be specific for a subsystem. If the patch
> is correct, it belongs into the networking core.
To me it sounds a bit intrusive to change the networking core for
something that has so far only been seen with devices belonging to one
subsystem, but I will do it if required. I guess David M. will have an
opinion on if we should add this fix on a per-driver basis, in usbnet
or in the networking core? If we go for the latter, what would be
correct place for this piece of code, register_netdevice()?