Re: [PATCH 2/2] tpm: fix byte-order for the value read by tpm2_get_tpm_pt
From: Jarkko Sakkinen
Date: Mon Jul 18 2016 - 15:06:04 EST
On Fri, Jul 15, 2016 at 01:39:28PM -0600, Jason Gunthorpe wrote:
> On Fri, Jul 15, 2016 at 12:31:43PM -0700, Andrey Pronin wrote:
> > I even tried changing the code there to
> > __be32 vv = cmd.params.get_tpm_pt_out.value;
> > u32 ret = vv;
> > to make it clear what's going on. Still, no complaints from sparse.
> Hum, I'm not an expert at sparse, but I expect a warning from it here?
> Maybe Jarkko knows when he gets back?
I do run sparse regularly. If look at the commit log there are even
couple of recent bug fixes related to sparse errors.