Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling
From: Kristian Evensen
Date: Tue Jul 19 2016 - 02:40:46 EST
On Tue, Jul 19, 2016 at 8:20 AM, Oliver Neukum <oneukum@xxxxxxxx> wrote:
>> I had a look at some other drivers, and I think we need to be very
>> careful about making setting a random MAC too generic. For example, we
>> might be unlucky and break the possibly_iphdr()-code/assumption in
>> qmi_wwan.c. And there is probably more code/assumptions like that in
>> the network stack.
> In this case please use special cases for usbnet, too.
> We need a quirk.
I guess I can match on the VID/PID in usbnet, but won't it be cleaner
to add a new bind() function (in cdc_ether) which matches the two PIDs
and leave usbnet as is? Or am I misunderstanding how to add this
functionality to usbnet?