Re: [PATCH v2 2/3] acpi i2c: Initialize info.type from of_compatible
From: Mika Westerberg
Date: Tue Jul 19 2016 - 03:07:21 EST
On Wed, Jul 13, 2016 at 02:20:57PM +0200, Rafael J. Wysocki wrote:
> On Wed, Jul 13, 2016 at 1:53 PM, Crestez Dan Leonard
> <leonard.crestez@xxxxxxxxx> wrote:
> > When using devicetree i2c_board_info.type is set to the compatible
> > string with the vendor prefix removed. For I2C devices described via
> > ACPI the i2c_board_info.type string is set to the ACPI device name. When
> > using ACPI and DT ids this string ends up something like "PRP0001:00".
> > If the of_compatible property is present try to use that instead. This
> > makes it easier to instantiate i2c drivers through ACPI with DT ids.
> > Signed-off-by: Crestez Dan Leonard <leonard.crestez@xxxxxxxxx>
> Looks good to me, but Mika needs to have a look at it too.
Looks good to me,
Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>