Re: [PATCH v2] arm/perf: Convert to hotplug state machine

From: Mark Rutland
Date: Tue Jul 19 2016 - 05:57:58 EST


Hi,

On Tue, Jul 19, 2016 at 11:02:29AM +0200, Sebastian Andrzej Siewior wrote:
> +static int arm_pmu_hp_init(void)
> +{
> + int ret;
> +
> + ret = cpuhp_setup_state_nocalls(CPUHP_AP_PERF_ARM_STARTING,
> + "AP_PERF_ARM_STARTING",
> + arm_perf_starting_cpu, NULL);
> + if (ret)
> + pr_err("CPU hotplug notifier for ARM PMU could not be "
> + "registered: %d\n", ret);

Nit: Per Documentation/CodingStyle strings should always be on one line,
even if greater than 80 chars, so they're greppable. I assume that can
be fixed up when this is picked.

Otherwise, v2 looks correct to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Thanks,
Mark.