Re: [RFC 3/3] kexec: extend kexec_file_load system call
From: Vivek Goyal
Date: Tue Jul 19 2016 - 08:24:13 EST
On Tue, Jul 19, 2016 at 11:52:00AM +0100, Mark Rutland wrote:
> On Tue, Jul 19, 2016 at 08:55:56AM +0800, Dave Young wrote:
> > On 07/18/16 at 11:07am, Mark Rutland wrote:
> > > On Mon, Jul 18, 2016 at 10:30:24AM +0800, Dave Young wrote:
> > > > I do not think it is worth to add another syscall for extra fds.
> > > > We have open(2) as an example for different numbers of arguments
> > > > already.
> > >
> > > Did we change the syscall interface for that?
> > >
> > > I was under the impression that there was always one underlying syscall,
> > > and the C library did the right thing to pass the expected information
> > > to the underlying syscall.
> > I'm not sure kexec_load and kexec_file_load were included in glibc, we use
> > syscall directly in kexec-tools.
> > kexec_load man pages says there are no wrappers for both kexec_load and
> > kexec_file_load in glibc.
> For the above, I was talking about how open() was handled.
> If there are no userspace wrappers, then the two cases aren't comparable
> in the first place...
> > > That's rather different to changing the underlying syscall.
> > >
> > > Regardless of how this is wrapped in userspace, I do not think modifying
> > > the existing prototype is a good idea, and I think this kind of
> > > extension needs to be a new syscall.
> > Hmm, as I replied to Vivek, there is one case about the flags, previously
> > the new flag will be regarded as invalid, but not we extend it it will be
> > valid, this maybe the only potential bad case.
> It's true that adding suport for new flags will change the behaviour of
> what used to be error cases. We generally expect real users to not be
> making pointless calls for which they rely on an error being returned in
> all cases.
> Regardless, this extended syscall changes some underlying assumptions
> made with the development of kexec_file_load, and I think treating this
> as an extension is not a great idea. From a user's perspective there is
> little difference between passing an additional flag or using a
> different syscall number, so I don't think that we gain much by altering
> the existing prototype relative to allocating a new syscall number.
If we are providing/opening up additional flags, I can't think what will
it break. Same flag was invalid in old kernel but new kernel supports
it and will accept it. So it sounds reasonable to me to add new flags.
If existing users are not broken, then I think it might be a good idea
to extend existing syscall. Otherwise userspace will have to be modified
to understand a 3rd syscall also and an additional option will show up
which asks users to specify which syscall to use. So extending existing
syscall might keep it little simple for users.
This is only if conclusion in the end is that DT needs to be passed in
from user space.
BTW, does kexec_load() needs to be modified too to handle DT?