Re: [PATCH] mtd: nand: fix bug writing 1 byte less than page size
From: Brian Norris
Date: Tue Jul 19 2016 - 15:56:19 EST
On Mon, Jul 18, 2016 at 05:37:22PM -0500, Scott Wood wrote:
> On Mon, 2016-07-18 at 11:04 +0200, Boris Brezillon wrote:
> > On Mon, 18 Jul 2016 10:39:18 +0200
> > Hector Palacios <hector.palacios@xxxxxxxx> wrote:
> > >
> > > nand_do_write_ops() determines if it is writing a partial page with the
> > > formula:
> > > part_pagewr = (column || writelen < (mtd->writesize - 1))
> > >
> > > When 'writelen' is exactly 1 byte less than the NAND page size the formula
> > > equates to zero, so the code doesn't process it as a partial write,
> > > although it should.
> > > As a consequence the function remains in the while(1) loop with 'writelen'
> > > becoming 0xffffffff and iterating endlessly.
> > >
> > > The bug may not be easy to reproduce in Linux since user space tools
> > > usually force the padding or round-up the write size to a page-size
> > > multiple.
> > > This was discovered in U-Boot where the issue can be reproduced by
> > > writing any size that is 1 byte less than a page-size multiple.
> > > For example, on a NAND with 2K page (0x800):
> > > => nand erase.part <partition>
> > > => nand write $loadaddr <partition> 7ff
> > >
> > > Signed-off-by: Hector Palacios <hector.palacios@xxxxxxxx>
> > Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> > Brian, can you take this patch in your tree.
> > As usual, I'm unsure whether we should Cc stable or not, but we
> > should at least add
> > Fixes: 66507c7bc8895 ("mtd: nand: Add support to use nand_base poi databuf
> > as bounce buffer")
> That commit just moved the bad test; it was introduced in 29072b96078ffde3
> ("[MTD] NAND: add subpage write support").
Indeed. I've update the Fixes tag and added an additional comment in the