Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio

From: Mark Brown
Date: Tue Jul 19 2016 - 20:21:43 EST

On Tue, Jul 19, 2016 at 02:59:31PM -0700, John Stultz wrote:

> Then the probe/remove logic to register the codec, and connected it up
> with the simple card driver.

> Though it seems kind of silly to have a whole driver (and devicetree
> entry for the probe hook) just to fill and install the above
> structure. Is there a simpler way to specify that via a DT node
> instead?

Well, if you can use simple-card why not just use simple-card?

> >> +static const struct of_device_id hi6210_i2s_dt_ids[] = {
> >> + { .compatible = "hisilicon,hi6210-i2s" },
> >> + { /* sentinel */ }
> >> +};

> > The code makes this look like it's not just an I2S controller.

> I'm not sure I follow this? The dt ids make it seem like this driver
> is not an i2s controller?

No. The *code* makes this look like it's not an I2S controller. It
looks like it's a driver for a DSP/mixing block which may have an
integrated I2S controller, I pointed out things like some of the routing

Attachment: signature.asc
Description: PGP signature