Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state
From: David Miller
Date: Tue Jul 19 2016 - 22:23:03 EST
From: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Mon, 18 Jul 2016 13:02:47 -0700
> txr->dev_state was not consistently manipulated with the acquisition of
> the per-queue lock, after further inspection the lock does not seem
> necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0.
> Reported-by: coverity (CID 1339583)
> Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Changes in v2:
> - remove locking in bnxt_tx_disable() as recommended by Michael
Applied to net-next, thanks.