Re: [Patch-V2 2/3] chcr: Support for Chelsio's Crypto Hardware

From: David Miller
Date: Wed Jul 20 2016 - 00:15:31 EST

From: Yeshaswi M R Gowda <yeshaswi@xxxxxxxxxxx>
Date: Mon, 18 Jul 2016 22:42:14 -0700

> + tristate "Chelsio Crypto Co-processor Driver"
> + depends on PCI && NETDEVICES && ETHERNET
> + select CRYPTO_SHA1
> + select CRYPTO_SHA256
> + select CRYPTO_SHA512
> + select CHELSIO_T4

The user shouldn't have to know about the technical details about
how this chip is physically implemented.

It's therefore not reasonable to require an ethernet driver to be
enabled to use the crypto engine.

Also, selecting Kconfig symbol X does not recursively enable the
"select" statement(s) of symbol X nor does it check symbol X's

This is really one big huge dependency mess, and I think you have
to split out the core of the T4 driver into a driver subtype
agnostic library or similar to make this work properly.

Don't just shoehorn this stuff into the ethernet driver. Round
peg, square hole.