Re: v4.1 to v4.7: regression in tsc2005 driver

From: Pavel Machek
Date: Wed Jul 20 2016 - 02:26:08 EST


Hi!

> > > > > > > drivers/input/touchscreen/tsc2005.c: input_dev->name = "TSC2005
> > > > > > > touchscreen";
> > > > > > >
> > > > > > > to "TSC200X touchscreen". Unfortunately, X seems to propagate that
> > > > > > > name to userspace, where it is needed to be able to do
>
> Technically X _is_ userspace.

There's "userspace running as root" and "userspace userspace" :-).

> > > > > > >
> > > > > > > xinput --set-prop --type=int ...
> > > > > > >
> > > > > > > with the right arguments to calibrate touchscreen. (Touchscreen is
> > > > > > > unusable without calibration).
> > > > > > >
> > > > > > > What to do with that?
>
> Hmm, I do not think we ever committed for the device names to be stable.
> You are supposed to locate touchscreen device based on its properties
> and you might need some heuristic if you encounter a system with more
> than one such touchscreen.

Well, you are commited now, like it or not, X people did it for you
:-(.

Because there's no other reasonable way to use xinput --set-prop...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html