Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups
From: Greg Ungerer
Date: Wed Jul 20 2016 - 03:17:38 EST
On 20/07/16 16:54, Geert Uytterhoeven wrote:
> Hi Nicolas,
> On Wed, Jul 20, 2016 at 6:09 AM, Nicolas Pitre <nicolas.pitre@xxxxxxxxxx> wrote:
>> On Tue, 19 Jul 2016, Geert Uytterhoeven wrote:
>>> On Tue, Jul 19, 2016 at 6:52 AM, Greg Ungerer <gerg@xxxxxxxxxxxxxx> wrote:
>>>> Seeing as you have modified quite a few printk calls is it worth
>>>> while annotating them with appropriate KERN_ERR, KERN_INFO, etc?
>>> You mean pr_err(), pr_info(), ... ;-)
>> Done. Included in v3.
> Really? The only change in v3 is the Reviewed-by?
Patch 2 in the series now does this:
[PATCH v3 02/12] binfmt_flat: convert printk invocations to their modern form
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds