Re: [PATCH] gpio: tegra: don't auto-enable for COMPILE_TEST
From: Ingo Molnar
Date: Wed Jul 20 2016 - 06:42:22 EST
* Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Wed, Jul 6, 2016 at 2:54 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > I stumbled over a build error with COMPILE_TEST and CONFIG_OF
> > disabled:
> > drivers/gpio/gpio-tegra.c: In function 'tegra_gpio_probe':
> > drivers/gpio/gpio-tegra.c:603:9: error: 'struct gpio_chip' has no member named 'of_node'
> > The problem is that the newly added GPIO_TEGRA Kconfig symbol
> > does not have a dependency on CONFIG_OF. However, there is another
> > problem here as the driver gets enabled unconditionally whenever
> > COMPILE_TEST is set.
> > This fixes both problems, by making the symbol user-visible
> > when COMPILE_TEST is set and default-enabled for ARCH_TEGRA=y.
> > As a side-effect, it is now possible to compile-test a Tegra
> > kernel with GPIO support disabled, which is harmless.
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Fixes: 4dd4dd1d2120 ("gpio: tegra: Allow compile test")
> Patch applied.
This is still not upstream and this build failure is very prominent in the
upstream kernel right now.
> I'm starting to get a bit tired about anything related to compile testing.
They are very useful in finding real problems as well, and some people
(like me! :-) rely on being able to generate random kernel images and