Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

From: Catalin Marinas
Date: Wed Jul 20 2016 - 11:50:13 EST


On Fri, Jul 08, 2016 at 12:35:48PM -0400, David Long wrote:
> +#define MIN_STACK_SIZE(addr) (on_irq_stack(addr, raw_smp_processor_id()) ? \
> + min((unsigned long)IRQ_STACK_SIZE, \
> + IRQ_STACK_PTR(raw_smp_processor_id()) - (addr)) : \
> + min((unsigned long)MAX_STACK_SIZE, \
> + (unsigned long)current_thread_info() + THREAD_START_SP - (addr)))

I presume you've never tested the on_irq_stack() path in this macro.

--
Catalin