Re: [PATCH v2 01/10] v4l: of: add "newavmode" property for Analog Devices codecs
From: Steve Longerbeam
Date: Wed Jul 20 2016 - 13:14:31 EST
On 07/20/2016 12:37 AM, Hans Verkuil wrote:
> On 07/20/2016 02:03 AM, Steve Longerbeam wrote:
>> This patch adds a "newavmode" boolean property as part of the v4l2 endpoint
>> properties. This indicates an Analog Devices decoder is generating EAV/SAV
>> codes to suit Analog Devices encoders.
>> Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>
>> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
>> Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
>> Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++
>> drivers/media/v4l2-core/v4l2-of.c | 4 ++++
>> include/media/v4l2-mediabus.h | 5 +++++
>> 3 files changed, 11 insertions(+)
>> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt
>> index 9cd2a36..6f2df51 100644
>> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
>> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
>> @@ -88,6 +88,8 @@ Optional endpoint properties
>> - field-even-active: field signal level during the even field data transmission.
>> - pclk-sample: sample data on rising (1) or falling (0) edge of the pixel clock
>> +- newavmode: a boolean property to indicate an Analog Devices decoder is
>> + operating in NEWAVMODE. Valid for BT.656 busses only.
> This property is adv7180 specific and does not belong here.
Hi Hans, yes that was my initial reaction to this idea as well, but
you didn't respond to my first request for comment.
> Add this to Documentation/devicetree/bindings/media/i2c/adv7180.txt instead.
Yes, I'll move this property into adv7180.