Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

From: Arnd Bergmann
Date: Wed Jul 20 2016 - 16:35:42 EST


On Wednesday, July 20, 2016 1:31:48 PM CEST Scott Wood wrote:
> On Wed, 2016-07-20 at 13:24 +0200, Arnd Bergmann wrote:
> > On Saturday, July 16, 2016 9:50:21 PM CEST Scott Wood wrote:
> > >
> > > From: yangbo lu <yangbo.lu@xxxxxxx>
> > >
> > > Move mpc85xx.h to include/linux/fsl and rename it to svr.h as a common
> > > header file. This SVR numberspace is used on some ARM chips as well as
> > > PPC, and even to check for a PPC SVR multi-arch drivers would otherwise
> > > need to ifdef the header inclusion and all references to the SVR symbols.
> > >
> > > Signed-off-by: Yangbo Lu <yangbo.lu@xxxxxxx>
> > > Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> > > Acked-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> > > Acked-by: Joerg Roedel <jroedel@xxxxxxx>
> > > [scottwood: update description]
> > > Signed-off-by: Scott Wood <oss@xxxxxxxxxxxx>
> > >
> > As discussed before, please don't introduce yet another vendor specific
> > way to match a SoC ID from a device driver.
> >
> > I've posted a patch for an extension to the soc_device infrastructure
> > to allow comparing the running SoC to a table of devices, use that
> > instead.
>
> As I asked before, in which relevant maintainership capacity are you NACKing
> this?

I don't know why that's important, but I suggested the creation of
drivers/soc/ as a place to have a more general place for platform
specific drivers as part of being maintainer for arm-soc, and
almost all changes to drivers/soc go through our tree.

Olof does about half the merges, but I do the majority of the reviews
for drivers/soc patches. See also

git log --graph --format="%an %s" --merges drivers/soc/

Arnd