Re: [PATCH] ARM: shmobile: don't call platform_can_secondary_boot on UP
From: Simon Horman
Date: Wed Jul 20 2016 - 19:15:31 EST
On Thu, Jun 30, 2016 at 03:09:46PM +0200, Geert Uytterhoeven wrote:
> Hi Arnd,
> On Thu, Jun 30, 2016 at 2:25 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > For rcar-gen2, we build the SMP files even for UP configurations,
> > and that just broke:
> > arch/arm/mach-shmobile/built-in.o: In function `shmobile_smp_init_fallback_ops':
> > pm-rcar-gen2.c:(.init.text+0x40c): undefined reference to `platform_can_secondary_boot'
> > This adds an compile-time check before the call to platform_can_secondary_boot,
> > turning the function into an empty stub for UP configurations.
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Fixes: c21af444eace ("ARM: shmobile: smp: Add function to prioritize DT SMP")
> Crap, I think I took the shortcut of only compile-testing
> not link-testing the whole kernel, with CONFIG_SMP=n...
> Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Sorry for missing this until now.
I have queued it up as a fix for v4.7.