[PATCH v3 2/4] powerpc/spinlock: support vcpu preempted check
From: Pan Xinhui
Date: Thu Jul 21 2016 - 03:46:47 EST
This is to fix some lock holder preemption issues. Some other locks
implementation do a spin loop before acquiring the lock itself.
Currently kernel has an interface of bool vcpu_is_preempted(int cpu). It
takes the cpu as parameter and return true if the cpu is preempted. Then
kernel can break the spin loops upon the retval of vcpu_is_preempted().
As kernel has used this interface, So lets support it.
Only pSeries need support it. And the fact is powerNV are built into same
kernel image with pSeries. So we need return false if we are runnig as
powerNV. The another fact is that lppaca->yield_count keeps zero on
powerNV. So we can just skip the machine type check.
Suggested-by: Boqun Feng <boqun.feng@xxxxxxxxx>
Suggested-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
Signed-off-by: Pan Xinhui <xinhui.pan@xxxxxxxxxxxxxxxxxx>
arch/powerpc/include/asm/spinlock.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/powerpc/include/asm/spinlock.h b/arch/powerpc/include/asm/spinlock.h
index 523673d..3ac9fcb 100644
@@ -52,6 +52,24 @@
+ * This support kernel to check if one cpu is preempted or not.
+ * Then we can fix some lock holder preemption issue.
+#define vcpu_is_preempted vcpu_is_preempted
+static inline bool vcpu_is_preempted(int cpu)
+ * pSeries and powerNV can be built into same kernel image. In
+ * principle we need return false directly if we are running as
+ * powerNV. However the yield_count is always zero on powerNV, So
+ * skip such machine type check
+ return !!(be32_to_cpu(lppaca_of(cpu).yield_count) & 1);
static __always_inline int arch_spin_value_unlocked(arch_spinlock_t lock)
return lock.slock == 0;