Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

From: Thomas Petazzoni
Date: Thu Jul 21 2016 - 08:47:10 EST


On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
> > Signed-off-by: Grzegorz Jaszczyk <jaz@xxxxxxxxxxxx>
> Why? It's not like this is an on-soc device, but most likely a PCIe card.
> Should we build-in all PCIe drivers?

I agree.

> I think it makes more sense to have this as a module rather than built-in.

I would prefer to not have it all in the defconfig. I'd hate to have
a defconfig that builds tons of random modules "just because".

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering