Re: [PATCH v6] ARM: sun4i: spi: Allow transfers larger than FIFO size

From: Michael Weiser
Date: Thu Jul 21 2016 - 09:16:14 EST

Hi all,

On Sat, Aug 08, 2015 at 09:41:51PM +0200, Olliver Schinagl wrote:

> Alexandru sent this patch over a year and a half ago, and I believe several
> tree's have been carrying it since. We've been using this patch on an
> Olimex OLinuxIno Lime1 and Lime2 using the mmc-spi driver to access SD cards
> without problems. So bumping this and adding my

I also have a need for this addition since it makes an ENC28J60 SPI
ethernet controller work on the Cubieboard2. I've successfully tested it
with 4.6.3 where it still applies cleanly.

(There's is a very minor conflict when applying against current Linus
master (EINVAL was changed to EMSGSIZE). I can supply a rebased version
if so desired.)

What is keeping the patch from being merged (i.e. into mainline)?


> Tested-by: Olliver Schinagl <oliver@xxxxxxxxxxx>

Tested-by: Michael Weiser <michael.weiser@xxxxxx>

> Changes from v5as warned by checkpatch. No functional changes.
> * Added some newlines to make checkpatch happy. No functional changes.

> Changes from v4:
> * use min3() instead of two if statements in sun4i_spi_fill_fifo()
> * fix trivial whitespace issue in if statement in sun4i_spi_handler()
> * use consistent style in assigning 'reg' in the added functions.

> Alexandru Gagniuc (1):
> ARM: sun4i: spi: Allow transfers larger than FIFO size

> drivers/spi/spi-sun4i.c | 76 +++++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 67 insertions(+), 9 deletions(-)