Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity
From: Juri Lelli
Date: Thu Jul 21 2016 - 10:36:51 EST
On 21/07/16 15:21, Juri Lelli wrote:
> On 18/07/16 21:37, Xunlei Pang wrote:
> > On 2016/07/18 at 21:04, Juri Lelli wrote:
> > > On 15/07/16 18:39, Xunlei Pang wrote:
> > >> On 2016/07/13 at 18:58, Juri Lelli wrote:
> > > [...]
> > >
> > >> Since this is only called for queued cases now, there is no need to
> > >> check boosted stuff here. As enqueue_task(ENQUEUE_REPLENISH)
> > >> is called before check_class_changed() in rt_mutex_setprio().
> > >>
> > > But we don't do the same in setscheduler, right?
> > If p is deadline PI-boosted, setscheduler() won't call change its sched_class.
> > If p isn't deadline PI-boosted, then pi_task is NULL.
> > So, I think the added code won't hit. Did I miss something?
> No, I think you are right.
Oh, and we need to filter the call after rt_mutex_setprio has
already issued a replenishment.
> I'll shoot a v5 ASAP (I think I'll put a WARN_ON just in case).
> - Juri