Re: [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches
From: Andrew Morton
Date: Thu Jul 21 2016 - 15:02:04 EST
On Thu, 21 Jul 2016 18:48:17 +0000 "Bounine, Alexandre" <Alexandre.Bounine@xxxxxxx> wrote:
> > > + udelay(10);
> > > + rio_write_config_32(rdev, RIO_PLM_SPx_IMP_SPEC_CTL(pnum),
> > rval);
> > > + mdelay(500);
> > Yikes, that's a very long busywait. A half-second machine freeze on
> > uniprocessor (if such exists ;)). We can't use msleep()?
> My bad ;) No problem with msleep() at all. We just need to give enough time
> for Rapidio link to get back (spec defines 500mS).
> Do you want a patch on patch?
Patch on patch is good. But something tested, please ;)