Re: [PATCH 09/19] x86/dumpstack: simplify in_exception_stack()
From: Andy Lutomirski
Date: Thu Jul 21 2016 - 18:05:24 EST
On Thu, Jul 21, 2016 at 2:21 PM, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> in_exception_stack() does some bad, bad things just so the unwinder can
> print different values for different areas of the debug exception stack.
> There's no need to clarify where exactly on the stack it is. Just print
> "#DB" and be done with it.
This is a huge improvement.
However: could you add a comment clarifying what purpose visit_mask serves?
FWIW, I have patches that remove the extra debug stacks, and they'll
be nicer on top of this.