Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()
From: Steve Muckle
Date: Thu Jul 21 2016 - 19:46:18 EST
On Fri, Jul 22, 2016 at 01:32:00AM +0200, Rafael J. Wysocki wrote:
> On Fri, Jul 22, 2016 at 1:22 AM, Steve Muckle <steve.muckle@xxxxxxxxxx> wrote:
> > On Fri, Jul 22, 2016 at 01:22:22AM +0200, Rafael J. Wysocki wrote:
> >> OK, applied.
> > FWIW I do have a concern on this patch, I think it adds unnecessary
> > overhead.
> It isn't unnecessary. It prevents an otherwise possible kernel crash
> from happening.
The logic may not be unecessary, but the overhead is. The crash could be
prevented in a way that doesn't require repeatedly checking a pointer
that doesn't change.