Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver

From: Jacek Anaszewski
Date: Fri Jul 22 2016 - 03:12:12 EST

On 07/22/2016 08:42 AM, H. Nikolaus Schaller wrote:

Am 22.07.2016 um 08:36 schrieb Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>:

On 07/20/2016 03:24 AM, Rob Herring wrote:
On Tue, Jul 19, 2016 at 01:47:31PM +0200, H. Nikolaus Schaller wrote:
Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
.../devicetree/bindings/leds/is31fl319x.txt | 59 ++++++++++++++++++++++
1 file changed, 59 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt

diff --git a/Documentation/devicetree/bindings/leds/is31fl319x.txt b/Documentation/devicetree/bindings/leds/is31fl319x.txt
new file mode 100644
index 0000000..03287c0
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/is31fl319x.txt
@@ -0,0 +1,59 @@
+LEDs connected to is31fl319x LED controller chip
+Required properties:
+- compatible : Should be any of
+ "issi,is31fl3190"
+ "issi,is31fl3191"
+ "issi,is31fl3193"
+ "issi,is31fl3196"
+ "issi,is31fl3199"
+ "si-en,sn3199".
+- #address-cells: Must be 1.
+- #size-cells: Must be 0.
+- reg: 0x64, 0x65, 0x66, 0x67.

This is an OR or AND? OR it seems. With that,

Nikolaus, could you please make it explicit?

Yes, Rob's intuition is right. An AND does
obviously not make sense for a reg property.

It is an OR.

So if you perfer, please substitute

- reg: 0x64, 0x65, 0x66, or 0x67.

Updated the for-4.9 branch accordingly. I also added "led-" prefix
to the file name to match it with the vast majority of the
remaining ones.

Best regards,
Jacek Anaszewski