Re: Aw: BUG: Wrong dma queue handling in ixp4 driver

From: Krzysztof HaÅasa
Date: Fri Jul 22 2016 - 06:23:30 EST

Hi Lino,

"Lino Sanfilippo" <LinoSanfilippo@xxxxxx> writes:

>> maybe I miss something, but the ixp4 ethernet driver seems to handle dma pools
>> in a wrong way: In init_queues() it creates a dma pool for descriptors and then
>> only allocates a single descriptor from this pool. The author seems to assume the whole
>> table has been allocated already, since after that the complete pool size is zeroed:
> Sorry, I indeed missed something. The allocation is correct. A pool is not required, though,
> since only one chunk is allocated.

Not really: there is one pool for all ports, but each port uses
a separate desc_tab (allocated from that pool).
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland