Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular"

From: Linus Walleij
Date: Fri Jul 22 2016 - 11:27:15 EST

On Tue, Jul 19, 2016 at 2:30 AM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:

> This reverts commit b8c2b10a9bc0272a20e096852f8fbbf361749dda.
> This patch was in my queue at the same time that a conversion of
> the same driver from bool --> tristate was pending and merged.
> That is commit 337ea0fb1535 ("pinctrl: Turn AMD support to tristate")
> Normally the conflict would show up in the build coverage I do,
> however in this case an avoidable instance of linux/module.h in
> linux/gpio/driver.h (!) causes the build failure to be masked and
> instead the tristate gets built-in even for selected "=m".
> In working on removing module.h from driver.h this issue was then
> revealed (along with other implicit module.h assumptions in gpio,
> and mfd -- which will be fixed separately.)
> Cc: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Patch applied with Jean's ACK.

Linus Walleij