Re: [PATCH v2] iio: dac: ad5380: Fix probe failure when no external reference is supplied

From: kbuild test robot
Date: Sat Jul 23 2016 - 11:16:03 EST


Hi,

[auto build test WARNING on iio/togreg]
[also build test WARNING on v4.7-rc7 next-20160722]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Pawe-Grudzi-ski/iio-dac-ad5380-Fix-probe-failure-when-no-external-reference-is-supplied/20160723-221946
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

drivers/iio/dac/ad5380.c: In function 'ad5380_probe':
>> drivers/iio/dac/ad5380.c:423:8: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
ret = st->vref_reg;
^

vim +423 drivers/iio/dac/ad5380.c

407 if (ret) {
408 dev_err(dev, "Failed to enable vref regulators: %d\n",
409 ret);
410 goto error_free_reg;
411 }
412
413 ret = regulator_get_voltage(st->vref_reg);
414 if (ret < 0)
415 goto error_disable_reg;
416
417 st->vref = ret / 1000;
418 } else {
419 if (PTR_ERR(st->vref_reg) == -ENODEV) {
420 st->vref = st->chip_info->int_vref;
421 ctrl |= AD5380_CTRL_INT_VREF_EN;
422 } else {
> 423 ret = st->vref_reg;
424 goto error_free_reg;
425 }
426 }
427
428 ret = regmap_write(st->regmap, AD5380_REG_SF_CTRL, ctrl);
429 if (ret) {
430 dev_err(dev, "Failed to write to device: %d\n", ret);
431 goto error_disable_reg;

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data